[Merge] lp:~phablet-team/qtubuntu-media/fix-1538703 into lp:qtubuntu-media

Alfonso Sanchez-Beato alfonso.sanchez-beato at canonical.com
Thu Mar 31 08:29:03 UTC 2016


One minor nit.

Diff comments:

> 
> === modified file 'tests/unit/service.cpp'
> --- tests/unit/service.cpp	2016-03-17 19:44:54 +0000
> +++ tests/unit/service.cpp	2016-03-29 23:54:02 +0000
> @@ -48,9 +44,8 @@
>  {
>  }
>  
> -std::shared_ptr<Player> TestService::create_fixed_session(const std::string& name, const Player::Configuration&)
> +std::shared_ptr<Player> TestService::create_fixed_session(const std::string&, const Player::Configuration&)

In these cases I like to comment out the variable to get some insight on what it is for, like

const std::string& /*name*/, ...

up to you to change it though.

>  {
> -    (void) name;
>      return 0;
>  }
>  


-- 
https://code.launchpad.net/~phablet-team/qtubuntu-media/fix-1538703/+merge/290219
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu-media.



More information about the Ubuntu-reviews mailing list