[Merge] lp:~gerboland/qtubuntu/make-up-physical-size-if-mir-says-0x0 into lp:qtubuntu

[Nick Dedekind]

Review: Needs Fixing

Looks ok; just one comment.

Diff comments:

> === modified file 'src/ubuntumirclient/screen.cpp'
> --- src/ubuntumirclient/screen.cpp	2016-04-28 14:09:54 +0000
> +++ src/ubuntumirclient/screen.cpp	2016-08-10 16:28:11 +0000
> @@ -155,13 +170,17 @@
>  
>      // Mode = Resolution & refresh rate
>      const MirOutputMode *mode = mir_output_get_current_mode(output);
> -    mNativeGeometry.setX(mir_output_get_position_x(output));
> -    mNativeGeometry.setY(mir_output_get_position_y(output));
> -    mNativeGeometry.setWidth(mir_output_mode_get_width(mode));
> -    mNativeGeometry.setHeight(mir_output_mode_get_height(mode));
> +    mGeometry.setX(mir_output_get_position_x(output));
> +    mGeometry.setY(mir_output_get_position_y(output));
> +    mGeometry.setWidth(mir_output_mode_get_width(mode));
> +    mGeometry.setHeight(mir_output_mode_get_height(mode));
>  
>      mRefreshRate = mir_output_mode_get_refresh_rate(mode);
>  
> +    // Physical screen size (in mm)
> +    QSize mirPhysicalSize(mir_output_get_physical_width_mm(output), mir_output_get_physical_height_mm(output));
> +    mPhysicalSize = setPhysicalSize(mirPhysicalSize, mGeometry.size());

what are you setting? getPhysicalSize/fromPhysicalSize

> +
>      // UI scale & DPR
>      mScale = mir_output_get_scale_factor(output);
>      if (overrideDevicePixelRatio > 0) {


-- 
https://code.launchpad.net/~gerboland/qtubuntu/make-up-physical-size-if-mir-says-0x0/+merge/302578
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.