[Merge] lp:~phablet-team/messaging-app/fix_qml_tests into lp:messaging-app/staging

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Mon Nov 14 15:05:06 UTC 2016


Comment replied.

Diff comments:

> === modified file 'tests/qml/tst_SingleSim.qml'
> --- tests/qml/tst_SingleSim.qml	2016-11-11 20:47:00 +0000
> +++ tests/qml/tst_SingleSim.qml	2016-11-14 14:43:17 +0000
> @@ -100,15 +105,21 @@
>  
>          function setChatState(state) {}
>          function sendMessage(accountId, text, attachments, properties) {
> +            console.log("BLABLA called")

Already removed

>              chatEntryObject.messageSent(accountId, text, attachments, properties)
>          }
>      }
>  
> -    Loader {
> -        id: mainViewLoader
> -        active: false
> -        property string i18nDirectory: ""
> -        source: '../../src/qml/messaging-app.qml'
> +    Item {
> +        id: mainView
> +        property var account: testAccount
> +        property bool applicationActive: true
> +        function updateNewMessageStatus() {}
> +    }
> +
> +    Messages {
> +        id: messagesView
> +        active: true
>      }
>  
>      SignalSpy {


-- 
https://code.launchpad.net/~phablet-team/messaging-app/fix_qml_tests/+merge/310778
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-app/staging.



More information about the Ubuntu-reviews mailing list