[Merge] lp:~ken-vandine/content-hub/gtest_1_8 into lp:content-hub

Ken VanDine ken.vandine at canonical.com
Mon Nov 28 17:37:58 UTC 2016


Ken VanDine has proposed merging lp:~ken-vandine/content-hub/gtest_1_8 into lp:content-hub.

Commit message:
Fix build failure on zesty due to googletest 1.8. Also refactored tests/acceptance-tests/CMakeLists.txt to make adding tests less cumbersome.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1644062 in googletest (Ubuntu): "googletest 1.8.0-2 (on zesty) breaks existing builds [add_library cannot create target "gmock" ...]"
  https://bugs.launchpad.net/ubuntu/+source/googletest/+bug/1644062

For more details, see:
https://code.launchpad.net/~ken-vandine/content-hub/gtest_1_8/+merge/311968

Fix build failure on zesty due to googletest 1.8. Also refactored tests/acceptance-tests/CMakeLists.txt to make adding tests less cumbersome.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ken-vandine/content-hub/gtest_1_8 into lp:content-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 9450 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20161128/005aae99/attachment.diff>


More information about the Ubuntu-reviews mailing list