[Merge] lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap into lp:webbrowser-app
Andrew Hayzen
andrew.hayzen at canonical.com
Tue Oct 4 11:02:46 UTC 2016
Fixed the issues mentioned, please retest.
1) As discussed this was so that when you are moving the "large" tab and there are "small" tabs you can go past halfway.
2) Removed use of semi-colons at end of statements
3) Fixed, turns out the X position was being updated after the Width as it depended on it, updated the calculation now
4) All new properties in TabsBar are now readonly
In addition I've noticed another existing bug, the way the tab move() is done is on the onXChanged. It only ever moves the tab +/- 1 to the left/right. This appears fine on a small number of tabs, but if you have *many* tabs open and quickly move the tab from one end to the other. The animation on X occurs, but it doesn't cause every X value to be 'hit' as it needs to reach the target within the duration. Which then means that some of the moves are missed, leaving the tab in the middle and not all the way across.
This seems like a slightly invasive change, should I report a bug and fix it in another branch?
--
https://code.launchpad.net/~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap/+merge/307415
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list