[Merge] lp:~fboucault/webbrowser-app/startup_time into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Oct 10 08:19:59 UTC 2016


Review: Needs Fixing

I’ve been running autopilot tests on a phone, and one test is constistently failing:

  webbrowser_app.tests.test_history.TestHistory.test_expanded_history_view_header_swallows_clicks


This is because the history view is now instantiated asynchronously, so the test code must be modified to wait for the view to be available. The following patch fixes the problem:

=== modified file 'tests/autopilot/webbrowser_app/emulators/browser.py'
--- tests/autopilot/webbrowser_app/emulators/browser.py	2016-08-10 15:43:04 +0000
+++ tests/autopilot/webbrowser_app/emulators/browser.py	2016-10-10 08:17:48 +0000
@@ -179,9 +179,9 @@
     def get_history_view(self):
         try:
             if self.wide:
-                return self.select_single(HistoryViewWide)
+                return self.wait_select_single(HistoryViewWide)
             else:
-                return self.select_single(HistoryView)
+                return self.wait_select_single(HistoryView)
         except exceptions.StateNotFoundError:
             return None

Can you please apply it?
-- 
https://code.launchpad.net/~fboucault/webbrowser-app/startup_time/+merge/300730
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list