[Merge] lp:~ahayzen/webbrowser-app/dnd-tabs-001 into lp:webbrowser-app/staging

Olivier Tilloy olivier.tilloy at canonical.com
Thu Oct 27 08:15:12 UTC 2016


Review: Needs Fixing

Please revert the changes to the translation template, it’s causing merge conflicts.

'tabsBarHeight' should be of type 'real'

I don’t remember exactly why (there must be a good reason), but by convention the *Changed signals usually don’t take any parameters. Can you please remove them from DragHelper?

webbrowser_app.tests.test_multiple_windows.TestMultipleWindowsDrag.test_drag_tab_outside_new_window reliably fails on my laptop:

Traceback (most recent call last):
  File "/[…]/tests/autopilot/webbrowser_app/tests/test_multiple_windows.py", line 141, in test_drag_tab_outside_new_window
    self.assertThat(len(windows), Equals(2))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 2 != 1

-- 
https://code.launchpad.net/~ahayzen/webbrowser-app/dnd-tabs-001/+merge/308507
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app/staging.



More information about the Ubuntu-reviews mailing list