[Merge] lp:~renatofilho/qtorganizer5-eds/fix-1616040 into lp:qtorganizer5-eds

Charles Kerr charles.kerr at canonical.com
Mon Sep 5 16:17:01 UTC 2016


Review: Approve

LGTM, should work fine.

Only minor suggestion is we pull limitDate() 4x in a small paragraph of code.

If QOrganizerRecurrenceRule does something dumb like recalculating it each time limitDate() is called, be better call it just once and cache it in a const temporary.
-- 
https://code.launchpad.net/~renatofilho/qtorganizer5-eds/fix-1616040/+merge/303726
Your team Ubuntu Phablet Team is subscribed to branch lp:qtorganizer5-eds.



More information about the Ubuntu-reviews mailing list