[Merge] lp:~mitya57/indicator-keyboard/gnome-control-center into lp:indicator-keyboard

Dmitry Shachnev mitya57 at gmail.com
Wed Aug 30 12:24:29 UTC 2017


Dmitry Shachnev has proposed merging lp:~mitya57/indicator-keyboard/gnome-control-center into lp:indicator-keyboard.

Commit message:
Use gnome-control-center on non-Unity desktops.

Requested reviews:
  Alberts Muktupāvels (muktupavels)
  William Hua (attente)
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  Bug #1713548 in indicator-keyboard (Ubuntu): "Unable to set keyboard shortcut for layout switching from indicator-keyboard (Text Entry Settings menu item) on gnome-panel"
  https://bugs.launchpad.net/ubuntu/+source/indicator-keyboard/+bug/1713548

For more details, see:
https://code.launchpad.net/~mitya57/indicator-keyboard/gnome-control-center/+merge/329909

This indicator should use gnome-control-center on non-Unity desktops (i.e. GNOME Flashback), just like the other indicators do. The code has been adapted from indicator-sound (with some fixes for nullable and non-nullable variables).
-- 
Your team Indicator Applet Developers is requested to review the proposed merge of lp:~mitya57/indicator-keyboard/gnome-control-center into lp:indicator-keyboard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1721 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170830/31dce6e1/attachment.diff>


More information about the Ubuntu-reviews mailing list