[Merge] lp:~mterry/webbrowser-app/snap-appid into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Feb 13 09:45:46 UTC 2017


Thanks for this Michael. That looks good to me, see only one minor comment inline.

Diff comments:

> === modified file 'snap/webbrowser-app.launcher'
> --- snap/webbrowser-app.launcher	2016-10-07 14:42:55 +0000
> +++ snap/webbrowser-app.launcher	2017-02-09 22:21:05 +0000
> @@ -5,6 +5,6 @@
>  export OXIDE_NO_SANDBOX=1
>  
>  # Explicitly set APP_ID.
> -export APP_ID=webbrowser-app
> +export APP_ID=webbrowser-app_webbrowser-app_${SNAP_REVISION}

Why not use ${SNAP_NAME} for the first occurrence of "webbrowser-app"?

>  
>  exec "$SNAP/bin/desktop-launch" "webbrowser-app" --desktop_file_hint=unity8 "$@"


-- 
https://code.launchpad.net/~mterry/webbrowser-app/snap-appid/+merge/316909
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/webbrowser-app/snap-appid into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list