[Merge] lp:~phablet-team/qtubuntu-media/release-sink-properly into lp:qtubuntu-media
Jim Hodapp
jim.hodapp at canonical.com
Fri Feb 17 17:28:03 UTC 2017
Review: Needs Fixing code
One minor thing to fix.
Diff comments:
> === modified file 'src/aal/aalvideorenderercontrol.cpp'
> --- src/aal/aalvideorenderercontrol.cpp 2016-07-20 21:26:54 +0000
> +++ src/aal/aalvideorenderercontrol.cpp 2017-02-14 10:37:05 +0000
> @@ -274,6 +274,8 @@
> {
> if (m_textureId == 0) {
> m_textureId = static_cast<GLuint>(textureID);
> + // Remove old instances
> + m_videoSink = nullptr;
Uses m_videoSink.reset() instead.
> m_videoSink = m_service->createVideoSink(textureID);
> if (not m_videoSink)
> {
--
https://code.launchpad.net/~phablet-team/qtubuntu-media/release-sink-properly/+merge/317180
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu-media.
More information about the Ubuntu-reviews
mailing list