[Merge] lp:~alfonsosanchezbeato/qtvideo-node/mir-desktop-enablement into lp:qtvideo-node

[Jim Hodapp]

Review: Needs Information



Diff comments:

> === modified file 'src/shadervideoshader.cpp'
> --- src/shadervideoshader.cpp	2015-05-03 21:42:34 +0000
> +++ src/shadervideoshader.cpp	2017-02-14 10:30:44 +0000
> @@ -82,8 +82,12 @@
>  const char *ShaderVideoShader::fragmentShader() const
>  {
>      static const char *shader =
> -        "#extension GL_OES_EGL_image_external : require      \n"
> +        "#extension GL_OES_EGL_image_external : enable       \n"
> +        "#ifdef GL_OES_EGL_image_external                    \n"

Just to make sure I understand this before approving it, this first part of the block is for a phone or ARM type device. The second part, or the else block is for Classic. Correct? I assume you've tested this on a phone?

>          "uniform samplerExternalOES sTexture;                \n"
> +        "#else                                               \n"
> +        "uniform sampler2D sTexture;                         \n"
> +        "#endif                                              \n"
>          "uniform lowp float opacity;                         \n"
>          "varying highp vec2 qt_TexCoord;                     \n"
>          "void main()                                         \n"


-- 
https://code.launchpad.net/~alfonsosanchezbeato/qtvideo-node/mir-desktop-enablement/+merge/317179
Your team Ubuntu Phablet Team is subscribed to branch lp:qtvideo-node.