[Merge] lp:~jonas-drange/ubuntu-ui-extras/dedupe-requests into lp:~phablet-team/ubuntu-ui-extras/printer-components

[Andrew Hayzen]

Review: Needs Information

Looks good, one inline comment.

1) As there is only ever going to be one instance of each printerName in the list, can this not be a QSet ?

Diff comments:

> 
> === modified file 'modules/Ubuntu/Components/Extras/Printers/backend/backend_cups.h'
> --- modules/Ubuntu/Components/Extras/Printers/backend/backend_cups.h	2017-02-23 14:04:26 +0000
> +++ modules/Ubuntu/Components/Extras/Printers/backend/backend_cups.h	2017-02-24 12:30:01 +0000
> @@ -126,6 +126,10 @@
>      int m_cupsSubscriptionId;
>      mutable QMap<QString, cups_dest_t*> m_dests; // Printer name, dest.
>      mutable QMap<QString, ppd_file_t*> m_ppds; // Printer name, ppd.
> +    QList<QString> m_activeRequests;

As there is only ever going to be one instance of each printerName in the list, can this not be a QSet ?

> +
> +private Q_SLOTS:
> +    void onPrinterLoaded(QSharedPointer<Printer> printer);
>  };
>  
>  #endif // USC_PRINTERS_CUPS_BACKEND_H


-- 
https://code.launchpad.net/~jonas-drange/ubuntu-ui-extras/dedupe-requests/+merge/318218
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-ui-extras/printer-components.