[Merge] lp:~ahayzen/ubuntu-settings-components/defaults-emit-to-qml-printermodel-getter-and-multi-remove-fix into lp:~phablet-team/ubuntu-settings-components/printer-components

Jonas G. Drange jonas.drange at canonical.com
Thu Jan 19 13:20:22 UTC 2017


Review: Approve

Looks good. Nitpick: I would make refresh() a slot that you connect e.g. descriptionChanged to. Makes the setters less knowledgeable.
-- 
https://code.launchpad.net/~ahayzen/ubuntu-settings-components/defaults-emit-to-qml-printermodel-getter-and-multi-remove-fix/+merge/315114
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-settings-components/printer-components.



More information about the Ubuntu-reviews mailing list