[Merge] lp:~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes into lp:~phablet-team/ubuntu-settings-components/printer-components
Andrew Hayzen
andrew.hayzen at canonical.com
Thu Jan 19 19:54:36 UTC 2017
Andrew Hayzen has proposed merging lp:~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes into lp:~phablet-team/ubuntu-settings-components/printer-components.
Commit message:
* Fix colorModelType not emitting when it may have changed, causing QML to get out of sync
* Add a Printers::allPrintersWithPdf option which includes a fake pdf at the bottom
* Add a PrinterInfoAllImpl which combines PrinterInfoPdfImpl and PrinterInfoImpl for listing
* Add a PrinterInfoPdfImpl which implements a fake pdf printer (just a name in the list)
* Add isPdf role to PrinterModel
* Add filterOnPdf to PrinterModel to allow for only showing pdf printers
* Force pdf printers to bottom of the PrinterModel
* Inject a fake ColorModel in PrinterPrivate::loadColorModel for pdf printers
* Change PrinterJob::setPrinterName to use PrinterInfoAllImpl for retreiving the PrinterInfo
* Improve the UI names for the Duplex modes
* Improve detection of color models so that "black" is a greyscale type
* In the example disable duplex mode when there is only None
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes/+merge/315169
* Fix colorModelType not emitting when it may have changed, causing QML to get out of sync
* Add a Printers::allPrintersWithPdf option which includes a fake pdf at the bottom
* Add a PrinterInfoAllImpl which combines PrinterInfoPdfImpl and PrinterInfoImpl for listing
* Add a PrinterInfoPdfImpl which implements a fake pdf printer (just a name in the list)
* Add isPdf role to PrinterModel
* Add filterOnPdf to PrinterModel to allow for only showing pdf printers
* Force pdf printers to bottom of the PrinterModel
* Inject a fake ColorModel in PrinterPrivate::loadColorModel for pdf printers
* Change PrinterJob::setPrinterName to use PrinterInfoAllImpl for retreiving the PrinterInfo
* Improve the UI names for the Duplex modes
* Improve detection of color models so that "black" is a greyscale type
* In the example disable duplex mode when there is only None
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes into lp:~phablet-team/ubuntu-settings-components/printer-components.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 24713 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170119/3f5c94a7/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list