[Merge] lp:~ahayzen/ubuntu-ui-extras/printer-components-add-role-tests into lp:~phablet-team/ubuntu-ui-extras/printer-staging

Andrew Hayzen andrew.hayzen at canonical.com
Thu Mar 2 12:52:35 UTC 2017


Andrew Hayzen has proposed merging lp:~ahayzen/ubuntu-ui-extras/printer-components-add-role-tests into lp:~phablet-team/ubuntu-ui-extras/printer-staging.

Commit message:
* Add tests for JobModel roles
* Add tests for make and location in Printer
* Fix JobModel color and quality roles to use fallback if no text
* Add tests for all roles in PrinterModel
* Remove PdfRole it is not used (IsPdfRole instead)

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-ui-extras/printer-components-add-role-tests/+merge/318765

* Add tests for JobModel roles
* Add tests for make and location in Printer
* Fix JobModel color and quality roles to use fallback if no text
* Add tests for all roles in PrinterModel
* Remove PdfRole it is not used (IsPdfRole instead)
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/ubuntu-ui-extras/printer-components-add-role-tests into lp:~phablet-team/ubuntu-ui-extras/printer-staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 39534 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170302/a9e60a8c/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list