[Merge] ~ovidiu-florin/ka:master into ka:master

Jose Manuel Santamaria Lema panfaust at gmail.com
Thu Mar 2 16:42:54 UTC 2017


Review: Approve

Hi,

I have retried with your latest changes and seems to work fine after a quick test with chromium and firefox. Still doesn't work with my yakkety's konqueror, however, what you are proposing looks already better than what we have right now (even if it doesn't work on all possible browsers), so I would mark this as "Approved".

Also note that I have reviewed this from a user point of view. Unfortunately, I don't know enough about JavaScript/HTML to have a great opinion about the code itself, but I hope it's ok.
-- 
https://code.launchpad.net/~ovidiu-florin/ka/+git/ka/+merge/318326
Your team Kubuntu Packagers is subscribed to branch ka:master.



More information about the Ubuntu-reviews mailing list