[Merge] lp:~fboucault/webbrowser-app/fix_fullscreen into lp:webbrowser-app/staging
Olivier Tilloy
olivier.tilloy at canonical.com
Fri Mar 3 14:47:26 UTC 2017
LGTM. Just one tiny comment inline.
Diff comments:
>
> === modified file 'src/app/webbrowser/Browser.qml'
> --- src/app/webbrowser/Browser.qml 2017-02-16 17:25:49 +0000
> +++ src/app/webbrowser/Browser.qml 2017-02-23 13:30:45 +0000
> @@ -513,7 +510,7 @@
> ChromeController {
> id: chromeController
> webview: browser.currentWebview
> - forceHide: browser.fullscreen
> + forceHide: browser.currentWebview.fullscreen
To avoid console warnings when browser.currentWebview is null, please do:
forceHide: webview ? webview.fullscreen : false
> forceShow: recentView.visible
> defaultMode: (internal.hasMouse && !internal.hasTouchScreen)
> ? Oxide.LocationBarController.ModeShown
--
https://code.launchpad.net/~fboucault/webbrowser-app/fix_fullscreen/+merge/318091
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~fboucault/webbrowser-app/fix_fullscreen into lp:webbrowser-app/staging.
More information about the Ubuntu-reviews
mailing list