[Merge] lp:~fboucault/webbrowser-app/history_domain_no_extra_sorting into lp:webbrowser-app/staging

[Andrew Hayzen]

Review: Needs Fixing

I'm getting the following two failures with this branch that I wasn't getting in staging.


2: QWARN  : QmlTests::HistoryView::test_delete_multiple_domains() file:///tmp/webbrowser/history_domain_no_extra_sorting/src/app/webbrowser/HistoryView.qml:179: TypeError: Property 'get' of object HistoryDomainListModel(0x146be40) is not a function
2: FAIL!  : QmlTests::HistoryView::test_delete_multiple_domains() property selectMode
2:    Actual   (): true
2:    Expected (): false
2:    Loc: [/tmp/webbrowser/history_domain_no_extra_sorting/tests/unittests/qml/tst_HistoryView.qml(153)]


2: QWARN  : QmlTests::HistoryView::test_select_all() file:///tmp/webbrowser/history_domain_no_extra_sorting/src/app/webbrowser/HistoryView.qml:179: TypeError: Property 'get' of object HistoryDomainListModel(0x1c73c70) is not a function
2: FAIL!  : QmlTests::HistoryView::test_select_all() property count
2:    Actual   (): 3
2:    Expected (): 0
2:    Loc: [/tmp/webbrowser/history_domain_no_extra_sorting/tests/unittests/qml/tst_HistoryView.qml(190)]



Also note in both this branch and staging flake8 fails for me with the following, looks like a regression has slipped into staging. (this issue can be fixed in another branch or in this one)

1: /tmp/webbrowser/staging/tests/autopilot/webbrowser_app/tests/test_fullscreen.py:102:1: E302 expected 2 blank lines, found 1
1: /tmp/webbrowser/staging/tests/autopilot/webbrowser_app/tests/test_fullscreen.py:106:80: E501 line too long (82 > 79 characters)

-- 
https://code.launchpad.net/~fboucault/webbrowser-app/history_domain_no_extra_sorting/+merge/319199
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app/staging.