[Merge] lp:~jonas-drange/ubuntu-ui-extras/remote-vs-local-printers into lp:~phablet-team/ubuntu-ui-extras/printer-staging
Jonas G. Drange
jonas.drange at canonical.com
Wed Mar 8 21:05:49 UTC 2017
Jonas G. Drange has proposed merging lp:~jonas-drange/ubuntu-ui-extras/remote-vs-local-printers into lp:~phablet-team/ubuntu-ui-extras/printer-staging.
Commit message:
allows browsing on local and remote printers
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~jonas-drange/ubuntu-ui-extras/remote-vs-local-printers/+merge/319088
allows browsing on local and remote printers
How to test (assumes USB or network printer):
1. Build the thing, run the example in gdb (it's known to crash):
gdb qmlscene
run -I <build folder>/modules/ <working dir>/modules/Ubuntu/Components/Extras/Example/Printers.qml
2. Press the "+"
3. Wait a bit until a list of network/usb printers is populated under "Other printers"
4. Click "Add Printer"
Expected:
A local copy of the printer, with the correct URL (dnssd or usb or socket) will appear in the list
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~jonas-drange/ubuntu-ui-extras/remote-vs-local-printers into lp:~phablet-team/ubuntu-ui-extras/printer-staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 53960 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170308/6c83989c/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list