[Merge] lp:~jonas-drange/ubuntu-ui-extras/copies into lp:~phablet-team/ubuntu-ui-extras/printer-staging
Andrew Hayzen
andrew.hayzen at canonical.com
Mon Mar 13 17:44:53 UTC 2017
Review: Needs Fixing
Found a small issue with this.
If you default printer has a copies value which is above 1, then when it is loaded PrinterJob doesn't get the default, it just gets 1. This is due to m_copies being set and PrinterJob::onPrinterAboutToChange trying to compare the previous printer before setting the default copies or the new (when in this case there is no previous).
I suggest adding a secondary case to PrinterJob::onPrinterAboutToChange, something similar to the following:
if (old == Q_NULLPTR || ... ) { setCopies(...) }
Which will then always set the default copies value for the first printer that is set.
--
https://code.launchpad.net/~jonas-drange/ubuntu-ui-extras/copies/+merge/319099
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-ui-extras/printer-staging.
More information about the Ubuntu-reviews
mailing list