[Merge] lp:~gerboland/qtubuntu/select-correct-dialog into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Tue Mar 14 13:38:36 UTC 2017


Gerry Boland has proposed merging lp:~gerboland/qtubuntu/select-correct-dialog into lp:qtubuntu.

Commit message:
Use correct parented/parentless dialog and utility window types from Mir

Fixes crash found in Qt's QWindow tests, where creating a parentless dialog caused an abort as we were trying to create a parented mir (modal) dialog with a null parent.

Requested reviews:
  Unity8 CI Bot (unity8-ci-bot): continuous-integration
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~gerboland/qtubuntu/select-correct-dialog/+merge/319816

Twinned upstream change: https://codereview.qt-project.org/#/c/188292/
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~gerboland/qtubuntu/select-correct-dialog into lp:qtubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1128 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170314/56cbd071/attachment.diff>


More information about the Ubuntu-reviews mailing list