[Merge] lp:~ahayzen/ubuntu-ui-extras/job-model-split-update into lp:~phablet-team/ubuntu-ui-extras/printer-staging

Andrew Hayzen andrew.hayzen at canonical.com
Wed Mar 15 17:30:52 UTC 2017


1) Not sure it needs this header?

Yup removed

2) s/FIXME/TODO :)

Fixed

3) Are you fixing this? Otherwise, could you rewrite it to be a TODO? Fixme's I associate with "fix before merging". :)
And in what cases aren't the newJob's printer fully loaded?

Changed, when in the Queue app it only uses the list of jobs and doesn't load any printers, so they are all proxytype.

4) Seems the timezone is set, but the time stamp does not it reflect it. E.g. time was 13:51 (UTC+1) and the time stamp in the job appeared as 12:51 GMT+0100.

Investigating on next commit...


Made the changes to JobLoader to return a QMap rather than a 'new' job.
-- 
https://code.launchpad.net/~ahayzen/ubuntu-ui-extras/job-model-split-update/+merge/319676
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-ui-extras/printer-staging.



More information about the Ubuntu-reviews mailing list