[Merge] lp:~phablet-team/telephony-service/fix_notification into lp:telephony-service/staging
Renato Araujo Oliveira Filho
renato.filho at canonical.com
Tue Mar 21 18:24:42 UTC 2017
> Can you change the commit message to reflect what the merge proposal actually
> does? It is replacing the platform-dependent code to open URLs by a supported
> url-dispatcher API.
>
> Also, this one would be a good one to have tests for (maybe by mocking the url
> dispatcher API?), but it doesn't have to be done in this merge proposal. Can
> you just add an entry to the TODO file mentioning that tests would be a good
> idea for this?
>
> Other than that, the code looks good.
Fixed.
--
https://code.launchpad.net/~phablet-team/telephony-service/fix_notification/+merge/316052
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/telephony-service/fix_protocol_filters.
More information about the Ubuntu-reviews
mailing list