[Merge] lp:~osomon/webbrowser-app/mir-libs into lp:webbrowser-app/staging

Olivier Tilloy olivier.tilloy at canonical.com
Tue Mar 28 14:07:35 UTC 2017


> I don't believe you need this line? But I'm not an expert and even
> if you don't need it, I think it's harmless, so fine.

I’m not sure either, but I’ll keep it for the sake of consistency with how we’re plugging to the platform snap.


> It's hard to say because this line isn't used by snapd at all yet, but
> I think you just need "mir-libs" here. c.f. the ubuntu-app-platform
> stanza below this one.

You’re probably right. I had just blindly copied what’s in https://bazaar.launchpad.net/~alan-griffiths/mircade-snap/trunk/view/head:/snap/snapcraft.yaml. I guess we’ll find out the day snapd starts making use of that line. I applied your suggestion.
-- 
https://code.launchpad.net/~osomon/webbrowser-app/mir-libs/+merge/321151
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/mir-libs into lp:webbrowser-app/staging.



More information about the Ubuntu-reviews mailing list