[Merge] lp:~renatofilho/sync-monitor/disable-sync-for-canonical into lp:sync-monitor
Charles Kerr
charles.kerr at canonical.com
Thu Mar 30 19:04:20 UTC 2017
Review: Approve
The gmock removal should have gone in a separate branch, IMO. This makes it harder to see the actual ~20 line patch
As to the actual patch... I'm a little worried that we carve out this special case, this patch looks like it cures the symptom rather than the underlying sync bug.
Still, as long as this is understood to be a temporary workaround for the inbox spam, and that this will be cleaned up when the sync bug is fixed, I'm OK with a temporary.
--
https://code.launchpad.net/~renatofilho/sync-monitor/disable-sync-for-canonical/+merge/320933
Your team Ubuntu Phablet Team is subscribed to branch lp:sync-monitor.
More information about the Ubuntu-reviews
mailing list