[Merge] lp:~tsimonq2/livecd-rootfs/proper-task-names into lp:livecd-rootfs

Julien Lavergne julien.lavergne at gmail.com
Tue May 16 23:23:29 UTC 2017


Review: Needs Fixing

Thanks Simon for the work on this :-)

I added inline comments about the change. Also, you probably want to add the following block to lubuntu-next part of the code, to do the same that the main seed :

# The Lubuntu STRUCTURE file has "feature
# no-follow-recommends".  Mirror this.
export APT_OPTIONS="--yes --no-install-recommends"
;;


Diff comments:

> === modified file 'live-build/auto/config'
> --- live-build/auto/config	2017-04-28 21:48:46 +0000
> +++ live-build/auto/config	2017-05-13 04:25:03 +0000
> @@ -332,7 +332,7 @@
>  
>  	lubuntu)
>  		add_task install minimal standard lubuntu-desktop
> -		LIVE_TASK='lubuntu-live'
> +		LIVE_TASK='lubuntu-live-gtk'

IMO, this shouldn't not be changed, as the default seed will always be lubuntu-live. If the default need to be changed, it should be on the seed side.

>  		case $ARCH in
>  			amd64)	add_package live linux-signed-generic ;;
>  		esac
> @@ -348,7 +348,7 @@
>  
>  	lubuntu-next)
>  		add_task install minimal standard lubuntu-qt-desktop
> -		LIVE_TASK='lubuntu-next-live'
> +		LIVE_TASK='lubuntu-live-qt'

Yes, it's the correct one.

>  		case $ARCH in
>  			amd64)	add_package live linux-signed-generic ;;
>  		esac


-- 
https://code.launchpad.net/~tsimonq2/livecd-rootfs/proper-task-names/+merge/324017
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~tsimonq2/livecd-rootfs/proper-task-names into lp:livecd-rootfs.



More information about the Ubuntu-reviews mailing list