[Merge] lp:~sil2100/update-manager/ignore_prompt_lts_for_non-lts into lp:update-manager

[Brian Murray]

This looks good to me, I just have a couple of in-line comments.

Diff comments:

> === modified file 'UpdateManager/Core/MetaRelease.py'
> --- UpdateManager/Core/MetaRelease.py	2018-03-15 10:22:01 +0000
> +++ UpdateManager/Core/MetaRelease.py	2018-08-28 11:29:46 +0000
> @@ -150,7 +151,14 @@
>                      self.downloaded.set()
>                      return
>                  elif type == "lts":

type seems like a bad name for a variable in python, could you fix this while you are working here?

> -                    self.METARELEASE_URI = self.METARELEASE_URI_LTS
> +                    # the Prompt=lts setting only makes sense when running on
> +                    # a lts, otherwise it would result in users not receiving

Its silly but I think lts should be capitalized in this comment.

> +                    # any distro upgrades
> +                    di = distro_info.UbuntuDistroInfo()
> +                    if di.is_lts(self.current_dist_name):
> +                        self.METARELEASE_URI = self.METARELEASE_URI_LTS
> +                    else:
> +                        self._debug("Prompt=lts for non-LTS, ignoring")
>          # needed for the _tryUpgradeSelf() code in DistUpgradeController
>          if forceLTS:
>              self.METARELEASE_URI = self.METARELEASE_URI_LTS


-- 
https://code.launchpad.net/~sil2100/update-manager/ignore_prompt_lts_for_non-lts/+merge/353851
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/update-manager/ignore_prompt_lts_for_non-lts into lp:update-manager.