[Merge] lp:~silhusk/software-properties/lp1656100-remove-signing-keys into lp:software-properties

[Carlo Vanini]

Carlo Vanini has proposed merging lp:~silhusk/software-properties/lp1656100-remove-signing-keys into lp:software-properties.

Commit message:
Fix removal of signing keys in the Authentication tab always failing.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1656100 in software-properties (Ubuntu): "Unable to remove signing keys using gnome-software-properties"
  https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1656100

For more details, see:
https://code.launchpad.net/~silhusk/software-properties/lp1656100-remove-signing-keys/+merge/361160

When clicking on "Remove" we were using the first 8 characters of the display string as a 32 bit (short) key ID. But what we get is the first half of a 64 bit ID, which is not a short ID. This fix uses all the 16 characters in the display string.

Remove calls to KeysModified(), which raise AttributeError because the function is not defined, and make remove_key() fail even though it did not (the "report this bug" dialog shows up). The same for update_keys and add_key.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~silhusk/software-properties/lp1656100-remove-signing-keys into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1885 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20181219/223c3128/attachment.diff>