[Merge] lp:~mwhudson/livecd-rootfs/subiquity-snapd-created-service into lp:livecd-rootfs

[Michael Hudson-Doyle]

Michael Hudson-Doyle has proposed merging lp:~mwhudson/livecd-rootfs/subiquity-snapd-created-service into lp:livecd-rootfs.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~mwhudson/livecd-rootfs/subiquity-snapd-created-service/+merge/337405

This, together with https://github.com/CanonicalLtd/subiquity/pull/280, fixes the current race condition we sometimes see with the live-server image by moving the creation of the subiquity service job to the subiquity snap. We can't set all of the options we need via snapd so there is still an systemd service overlay that adds them here.

This obviously can't land until the subiquity PR is in the stable channel for subiquity.

While we're here this simplifies the current game where getty at tty1.service starts and then stops again before subiquity takes over tty1 in favour of just disabling getty at tty1.service.

I have tested this and it seems to work. I don't know how to be sure the race condition is fixed.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~mwhudson/livecd-rootfs/subiquity-snapd-created-service into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2659 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20180209/be5fdf14/attachment.diff>