[Merge] lp:~vorlon/livecd-rootfs/ubuntu-channels-for-snaps into lp:livecd-rootfs

[Iain Lane]

Yeah, the current implementation isn't compliant with the spec.

Few questions inline, nothing major.

When ready to upload, please check the seeds to make sure nothing will fail to build due to this. For example I know that desktop is seeding snap:gnome-calculator ATM and it'll need to be published to the new channel.

Diff comments:

> 
> === modified file 'live-build/auto/build'
> --- live-build/auto/build	2018-01-30 10:16:36 +0000
> +++ live-build/auto/build	2018-02-16 22:09:43 +0000
> @@ -35,6 +35,8 @@
>  
>  preinstall_snaps() {
>  	lb chroot_resolv install
> +	snap_channel="stable/ubuntu-$(distro-info --series="$LB_DISTRIBUTION" \

If distro-info isn't guaranteed to be present in some way then this should be a Depends.

> +	                              -r | awk '{ print $1 }')"

What's the reason for using the version rather than the codename here, which would avoid the `-r' and pipe to awk?

I checked the spec (https://wiki.ubuntu.com/UbuntuSeededSnaps) and the channel scheme isn't spelled out there - can we make sure it is please?

>  	chroot chroot sh -c '
>  		set -x;
>  		cd /var/lib/snapd/seed;


-- 
https://code.launchpad.net/~vorlon/livecd-rootfs/ubuntu-channels-for-snaps/+merge/337897
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~vorlon/livecd-rootfs/ubuntu-channels-for-snaps into lp:livecd-rootfs.