[Merge] lp:~samuel-thibault/compiz/ezoom-minmax into lp:compiz

Alberts Muktupāvels alberts.muktupavels at gmail.com
Tue Jul 10 11:14:39 UTC 2018



Diff comments:

> 
> === modified file 'plugins/ezoom/src/ezoom.cpp'
> --- plugins/ezoom/src/ezoom.cpp	2017-12-05 14:45:06 +0000
> +++ plugins/ezoom/src/ezoom.cpp	2018-04-13 12:07:16 +0000
> @@ -736,8 +736,8 @@
>  	cursorZoomInactive ();
>      }
>  
> -    if (value < optionGetMinimumZoom ())
> -	value = optionGetMinimumZoom ();
> +    if (value < 1.0f / optionGetMaximumZoom())

Should not this be value > 1.0f..?

> +	value = 1.0f / optionGetMaximumZoom();
>  
>      zooms.at (out).newZoom = value;
>      cScreen->damageScreen();
> @@ -1931,7 +1931,7 @@
>  	float scale = MAX (width  / static_cast <float> (screen->outputDevs ().at (out).width ()),
>  			   height / static_cast <float> (screen->outputDevs ().at (out).height ()));
>  
> -	if (scale > optionGetAutoscaleMin ())
> +	if (scale > 1.0f / optionGetAutoscaleMax ())

Seem that this now should be scale < 1.0f..., no?

>  	    setScale (out, scale);
>      }
>  


-- 
https://code.launchpad.net/~samuel-thibault/compiz/ezoom-minmax/+merge/343183
Your team Compiz Maintainers is requested to review the proposed merge of lp:~samuel-thibault/compiz/ezoom-minmax into lp:compiz.



More information about the Ubuntu-reviews mailing list