[Merge] lp:~samuel-thibault/compiz/ezoom_focus_tracking into lp:compiz

Samuel thibault samuel.thibault at ens-lyon.org
Fri May 18 17:14:36 UTC 2018


Samuel thibault has proposed merging lp:~samuel-thibault/compiz/ezoom_focus_tracking into lp:compiz.

Commit message:
ezoom: add focus tracking based on at-spi a11y events.

This adds a focuspoll module which tracks focus events from a11y, used by ezoom concurrently to mouse events so the zoom moves nicely while working with the keyboard only.

Requested reviews:
  Compiz Maintainers (compiz-team)

For more details, see:
https://code.launchpad.net/~samuel-thibault/compiz/ezoom_focus_tracking/+merge/345941

Hello,

This is a resubmission of ksamak's work in https://code.launchpad.net/~ksamak/compiz/ezoom_focus_tracking, with (I believe) all raised comments addressed, notably:

- avoid the singleton technique
- avoid useless copies
- using smart pointers to avoid any memory leak
- better document at-spi workarounds

Samuel
-- 
Your team Compiz Maintainers is requested to review the proposed merge of lp:~samuel-thibault/compiz/ezoom_focus_tracking into lp:compiz.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 58333 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20180518/49632893/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list