[Merge] lp:~sil2100/livecd-rootfs/core-series-per-suite into lp:livecd-rootfs

Łukasz Zemczak lukasz.zemczak at canonical.com
Wed Oct 3 10:08:22 UTC 2018


Łukasz Zemczak has proposed merging lp:~sil2100/livecd-rootfs/core-series-per-suite into lp:livecd-rootfs.

Commit message:
Decide what model assertion series to fetch depending on the suite. Use 16 for xenial and 18 for other series (bionic+). This enables core18 image builds.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~sil2100/livecd-rootfs/core-series-per-suite/+merge/356040

Decide what model assertion series to fetch depending on the suite. Use 16 for xenial and 18 for other series (bionic+). This enables core18 image builds.

The decision to do it per-series comes from actually how cdimage determines what core series to use (with the core_series property). Since cdimage bases it on the distro series, I did the same here. We might think about adding yet another environment variable for this purpose but I would personally not want that. We already have enough parameters we're passing over to livecd-rootfs.

NOTE! It's best not to merge this just yet since apparently there are no official 18 series model assertions in the store yet. I have poked mvo about it.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/livecd-rootfs/core-series-per-suite into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1491 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20181003/54f52a63/attachment.diff>


More information about the Ubuntu-reviews mailing list