[Merge] ~mwhudson/livecd-rootfs/+git/livecd-rootfs:no-snaps-ubuntu-cpc-minimized into livecd-rootfs:ubuntu/master

Michael Hudson-Doyle mwhudsonlp at fastmail.fm
Mon Apr 8 23:02:56 UTC 2019



Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index 2626229..2896470 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -895,6 +895,22 @@ esac
>  if [ "$PASSES_TO_LAYERS" != "true" ] && [ -n "${BASE_SEED}" ]; then
>  	snap_from_seed "${BASE_SEED}" config/seeded-snaps
>  fi
> +if [ "$PROJECT:${SUBPROJECT:-}" = ubuntu-cpc:minimized ]; then
> +	# We install a lxc script that installs the snap when invoked. We don't
> +	# want any other snaps to come in without due consideration, so fail the
> +	# build if we see such a snap.
> +	for snap in `cat config/seeded-snaps`; do
> +		case $snap in
> +			lxd)
> +				;;
> +			*)
> +				echo "Unexpected seeded snap for ubuntu-cpc:minimized build: $snap"
> +				exit 1
> +				;;
> +		esac
> +	done
> +	rm config/seeded-snaps

Well, we don't want the core snap to be in the image either, right? We save more by skipping the core snap than we save by omitting lxd. Or do I misunderstand your point?

> +fi
>  
>  # grab a list of packags to remove for a "minimal" installation from the seed
>  # mirror for this project


-- 
https://code.launchpad.net/~mwhudson/livecd-rootfs/+git/livecd-rootfs/+merge/364222
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list