[Merge] ~rafaeldtinoco/ubuntu/+source/ndctl:lp1840485-focal into ubuntu/+source/ndctl:ubuntu/focal-devel

Rafael David Tinoco rafaeldtinoco at kernelpath.com
Sat Dec 7 07:45:41 UTC 2019


Rafael David Tinoco has proposed merging ~rafaeldtinoco/ubuntu/+source/ndctl:lp1840485-focal into ubuntu/+source/ndctl:ubuntu/focal-devel.

Commit message:
ubuntu: convert ndctl/test into qa-regression-ndctl tests
    
Adding regression tests based in existing upstream tests. While upstream
is worried about testing the entire pmem/dax stack (including kernel
libnvdimm using a mocked driver) our need is much simpler: to guarantee
the userland tool is good. This patch creates an autopkgtests with the
most important upstream tests to satisfy the need.
    
Note: *real* tests for nvdimms must be done in real HW OR in a QEMU
environment with emulated nvdimms: only the persistent memory mode is
available, not the block window mode (so tests using block window mode
were removed). A file called "vm-example.xml" is provided in order
to help creating needed autopkgtest environment.

Requested reviews:
  Christian Ehrhardt  (paelzer)
  Ubuntu Core Development Team (ubuntu-core-dev)
  Canonical Server Team (canonical-server)

For more details, see:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/ndctl/+git/ndctl/+merge/376487

Expected autopkgtest results:

sector-mode          PASS
ndctl-commands       PASS
daxctl-commands      PASS
blk-exhaust          PASS
btt-check            PASS
btt-pad-compat       PASS
dax-ext4             PASS
dax-xfs              PASS
label-compat         PASS
multi-dax            PASS
rescan-partitions    PASS
sector-mode          PASS

(using the virtual environment provided as example)

Tests will be skipped if no nvdimms are found.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rafaeldtinoco/ubuntu/+source/ndctl:lp1840485-focal into ubuntu/+source/ndctl:ubuntu/focal-devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 25101 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20191207/06b487c2/attachment.diff>


More information about the Ubuntu-reviews mailing list