[Merge] ~jibel/ubuntu-release-upgrader:testsuite_fixes into ubuntu-release-upgrader:ubuntu/master

[Jean-Baptiste Lallement]

Jean-Baptiste Lallement has proposed merging ~jibel/ubuntu-release-upgrader:testsuite_fixes into ubuntu-release-upgrader:ubuntu/master.

Commit message:
Fixed test_prepare_snap_replacement_data and increase coverage

Populate the cache with records for snap packages so DistUpgradeQuirks._prepare_snap_replacement_data doesn't crash when it checks the "installed" state of the package.

Added 2 cases to fully cover _prepare_snap_replacement_data:
1. A package installed but not tracking the release channel.
2. A package with a missing snap id.


Requested reviews:
  Brian Murray (brian-murray)
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~jibel/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/377046
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jibel/ubuntu-release-upgrader:testsuite_fixes into ubuntu-release-upgrader:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4574 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20191220/c891574b/attachment.diff>