[Merge] ~rafaeldtinoco/ubuntu/+source/samba:lp1831381-disco-devel-ctdb into ubuntu/+source/samba:ubuntu/disco-devel

[Christian Ehrhardt ]

Review: Needs Fixing

The actual changes match (thanks range-diff) what Andreas has already reviewed for Eoan.
So that part is ok.

For an SRU those are quite some big changes.
In the usual SRU fashion you need to explain why you need those SRUed.
For example your SRU Template in bug 722201 describes this as an issue of NFS settings, how does "enable syslog and systemd journal by default" (while generally a good change) tie into that from an SRU perspective.

You and Andreas might have gone deeper here already, but from my naive review I'd expect those to not be part of the SRU (and as mentioned before maybe explicit SRU testcases for bug 1821775 and bug 1828799):
   3   * debian/rules: Make DEB_HOST_ARCH_CPU initialized through                     
   4     dpkg-architecture (Closes: #931138)                                          
   5   * d/p/ctdb-config-enable-syslog-by-default.patch:                              
   6     enable syslog and systemd journal by default                                 
   7   * d/p/ctdb-config-depend-on-etc-default-nodes-file.patch:                      
   8     do not try to start daemon if /etc/ctdb/nodes does not exist                 
   9   * d/rules: installing provided config examples and helper scripts              
  10   * Examples of NFS HA CTDB config files + helper script:                        
  11     - d/ctdb.example.enable.nfs.sh                                               
  12     - d/ctdb.example.nfs-common                                                  
  13     - d/ctdb.example.nfs-kernel-server                                           
  14     - d/ctdb.example.services                                                    
  15     - d/ctdb.example.sysctl-nfs-static-ports.conf  
-- 
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/samba/+git/samba/+merge/370016
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rafaeldtinoco/ubuntu/+source/samba:lp1831381-disco-devel-ctdb into ubuntu/+source/samba:ubuntu/disco-devel.