[Merge] ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/cpc_duplicate_snaps into livecd-rootfs:ubuntu/master
Robert C Jennings
robert.jennings at canonical.com
Fri Mar 29 20:47:24 UTC 2019
Robert C Jennings has proposed merging ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/cpc_duplicate_snaps into livecd-rootfs:ubuntu/master.
Commit message:
ubuntu-cpc: avoid duplicate snaps listed in qcow manifest
commit a993592 introduced an additional call to create_manifest
(and snap-seed-parse) to write binary/boot/filesystem.packages. This
caused duplicate snap lines in the qcow manifest. This is because the
live-build/auto/binary code assumes that after 'lb binary' is run the
filesystem.packages will only have debs and it calls snap-seed-parse to
add them to the file. The commit changed filesystem.packages in the
ubuntu-cpc uefi binary hook to include debs and snaps.
This patch keeps the intent of the prior patch, updating the
filesystem.packages file for the content of the uefi disk image, but
only writes a listing of debian packages to match the expected content
of filesystem.packages. The snaps will still be added in generic code
in live-build/auto/build.
Requested reviews:
Canonical Cloudware (cloudware)
Ubuntu Core Development Team (ubuntu-core-dev)
For more details, see:
https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/365303
--
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/cpc_duplicate_snaps into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1613 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190329/e5827ac3/attachment.diff>
More information about the Ubuntu-reviews
mailing list