[Merge] ~mitya57/compiz:googletest into compiz:master
Dmitry Shachnev
mitya57 at gmail.com
Mon Nov 18 06:59:25 UTC 2019
Dmitry Shachnev has proposed merging ~mitya57/compiz:googletest into compiz:master.
Commit message:
Fix build with latest googletest, by using static libraries shipped by distro.
Requested reviews:
Alberts Muktupāvels (muktupavels)
Compiz Maintainers (compiz-team)
For more details, see:
https://code.launchpad.net/~mitya57/compiz/+git/compiz/+merge/375657
There is no need to compile googletest ourselves, when Ubuntu has pre-built binaries.
One may argue that this will work only on Debian/Ubuntu, but the previous code looking for source in /usr/src/googletest will also work only there. Anyway, if someone wants to re-introduce old code later, I will happily accept patches.
--
Your team Compiz Maintainers is requested to review the proposed merge of ~mitya57/compiz:googletest into compiz:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3044 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20191118/6e68015d/attachment.diff>
More information about the Ubuntu-reviews
mailing list