[Merge] lp:~tdaitx/ubuntu/groovy/apport/ubuntu into lp:~ubuntu-core-dev/ubuntu/groovy/apport/ubuntu

Brian Murray brian at ubuntu.com
Tue Sep 15 17:35:14 UTC 2020


Review: Needs Fixing

Suggested some rewording.

Diff comments:

> === modified file 'apport/ui.py'
> --- apport/ui.py	2020-08-04 22:48:01 +0000
> +++ apport/ui.py	2020-09-11 14:39:48 +0000
> @@ -141,7 +141,8 @@
>                          not apport.packaging.is_native_origin_package(report['Package'].split()[0]):
>                      # TRANS: %s is the name of the operating system
>                      report['UnreportableReason'] = _(
> -                        'This is not an official %s package. Please remove any third party package and try again.') % report['DistroRelease'].split()[0]
> +                        'This does not seem to be an official %s package. Please update all packages in your system,\n'

Saying to "update all packages" is inaccurate in that you don't really need to update all packages but rather the "indexes of available packages" (from man apt-get), so I think using words like that would be more accurate. Perhaps this would work "First try updating the indexes of available packages, if that does not work then remove related third party packages and try again."

I used related instead of any as it seems extreme to tell people to remove any, which implies all, third party packages.

> +                        'remove any third party package, and try again.\n') % report['DistroRelease'].split()[0]
>          except ValueError:
>              # this happens if we are collecting information on an uninstalled
>              # package


-- 
https://code.launchpad.net/~tdaitx/ubuntu/groovy/apport/ubuntu/+merge/390622
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/groovy/apport/ubuntu.



More information about the Ubuntu-reviews mailing list