[Merge] ~fnordahl/ubuntu/+source/ceph:bug/1940697-hirsute into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/hirsute

Christian Ehrhardt  mp+407593 at code.launchpad.net
Tue Aug 24 08:56:14 UTC 2021


Hi,
'm unsure who you expect to review this but I have seen this flying by and will give you a few quick hints.

1. you still target "UNRELEASED"
2. I haven't read into the case, but this sounds a bit like adding Features on SRUs?
   Reading the SRU template it seems more like re-adding a feature dropped by accident, so it 
   should be fine I guess.
3. nasm is in universe
   nasm | 2.15.05-1          | impish/universe          | source, amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

I have not seen a build log of yours (I generally recommend to add a PPA link to such MRs), but if ceph (main) adds a runtime dependency by this it would be a problem. Have you checked if this really is only having an impact at build time? If so I'd recommend to elaborate about it in the SRU template of your bug anyway.
-- 
https://code.launchpad.net/~fnordahl/ubuntu/+source/ceph/+git/ceph/+merge/407593
Your team Ubuntu Server Developers is requested to review the proposed merge of ~fnordahl/ubuntu/+source/ceph:bug/1940697-hirsute into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/hirsute.




More information about the Ubuntu-reviews mailing list