[Merge] ~fnordahl/ubuntu/+source/ceph:bug/1940697-hirsute into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/hirsute

Corey Bryant mp+407593 at code.launchpad.net
Wed Aug 25 13:06:24 UTC 2021


~/pkg/ussuri/upstream/ceph$ git-pretty v15.2.13..v16.2.0|grep -i nasm
 - [d72c9205dc0] cmake: only display the result of checking nasm once
 - [f22cb92d51f] nasm-wrapper: Make nasm-wrapper OS independent
 - [497b4d6f72a] cmake: remove yasm since it's been replaced by nasm
 - [58a946ca06a] cmake: use nasm to replace yasm to build isa-l
 - [a944232ad40] install-deps.sh: install nasm for isa-l library
 - [0042d244d48] cmake: wrapper nasm as assembler to deal with some options
 - [6d62cc05d94] cmake: check nasm and define related MACRO
 - [bf5794b2f08] cmake: define cmake macro to check nasm assembler

commit 497b4d6f72add5420b13df0d26ec48be37472adc
Author: Liu Changcheng <changcheng.liu at intel.com>
Date:   Wed Oct 28 15:26:41 2020 +0800

    cmake: remove yasm since it's been replaced by nasm
    
    Signed-off-by: Changcheng Liu <changcheng.liu at aliyun.com>


It seems we should drop yasm in addition to what you have here in this change. Could we update the commit message with more details point to the move from yasm to nasm? Worth noting, yasm was/is also in universe.
-- 
https://code.launchpad.net/~fnordahl/ubuntu/+source/ceph/+git/ceph/+merge/407593
Your team Ubuntu Server Developers is requested to review the proposed merge of ~fnordahl/ubuntu/+source/ceph:bug/1940697-hirsute into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/hirsute.




More information about the Ubuntu-reviews mailing list