[Merge] ~ethan.hsieh/livecd-rootfs/+git/livecd-rootfs:ubuntu/master into livecd-rootfs:ubuntu/master

[Thomas Bechtold]

Review: Needs Information



Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index d1be603..99e3bd5 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -548,7 +548,7 @@ _snap_preseed() {
>      sh -c "
>          set -x;
>          cd \"$CHROOT_ROOT/var/lib/snapd/seed\";
> -        SNAPPY_STORE_NO_CDN=1 snap download \
> +        UBUNTU_STORE_ARCH=$ARCH SNAPPY_STORE_NO_CDN=1 snap download \

where does $ARCH come from? Are we sure it's always set?

>              --cohort="${COHORT_KEY:-}" \
>              --channel=\"$CHANNEL\" \"$SNAP_NAME\"" || snap_download_failed=1
>      if [ $snap_download_failed = 1 ] ; then


-- 
https://code.launchpad.net/~ethan.hsieh/livecd-rootfs/+git/livecd-rootfs/+merge/405367
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~ethan.hsieh/livecd-rootfs/+git/livecd-rootfs:ubuntu/master into livecd-rootfs:ubuntu/master.