[Merge] ~toabctl/livecd-rootfs:master-replace-apt-key-lp#1948929 into livecd-rootfs:ubuntu/master

[Thomas Bechtold]

> Looks great, +1 from me.  Have you tested with this change?  And what options
> does a reviewer need to use to exercise this code path?

Until now I did only run the autopkgtests. I looked now how to exercise this code path.
>From what I see in livecd-rootfs, this code is executed if there is a directory called chroot/var/lib/preinstalled-pool . That directory is created in live-build/auto/config . For that, PREINSTALL_POOL_SEEDS needs to be set and that is only the case when PROJECT=ubuntu-server and SUBPROJECT=live .
So I tried to execute that with:

./scripts/ubuntu-bartender/ubuntu-bartender --livecd-rootfs-repo git+ssh://toabctl@git.launchpad.net/~toabctl/livecd-rootfs --livecd-rootfs-branch master-replace-apt-key-lp#1948929 -- --series impish --project ubuntu-server --subproject live

But that is failing with:

? Unknown dependency probert-network by probert on arch amd64
ERROR: PASSES_TO_LAYERS has changed from false to true between 2 API calls. Please set it first.
Build failed
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_livefs.py", line 176, in run
    self.build()
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_livefs.py", line 166, in build
    self.run_build_command(["lb", "config"], env=lb_env)
  File "/usr/lib/python3/dist-packages/lpbuildd/target/build_livefs.py", line 90, in run_build_command
    return self.backend.run(args, cwd="/build", **kwargs)
  File "/usr/lib/python3/dist-packages/lpbuildd/target/lxd.py", line 537, in run
    subprocess.check_call(cmd, **kwargs)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['lxc', 'exec', 'lp-impish-amd64', '--env', 'PROJECT=ubuntu-server', '--env', 'ARCH=amd64', '--env', 'SUBPROJECT=live', '--env', 'SUITE=impish', '--env', 'NOW=20211028.0941', '--env', 'IMAGEFORMAT=ext4', '--', '/bin/sh', '-c', 'cd /build && linux64 lb config']' returned non-zero exit status 1.


So either I do something wrong (not unlikely) or this code path is already broken...
-- 
https://code.launchpad.net/~toabctl/livecd-rootfs/+git/livecd-rootfs-1/+merge/410866
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.