[Merge] ~paelzer/update-notifier/+git/update-notifier:lp-1893716-reduce-login-overhead-JAMMY-nongu into update-notifier:master

Brian Murray mp+418122 at code.launchpad.net
Fri Apr 1 17:34:02 UTC 2022


This looks fine but I wonder if we extended the time frame see my inline comment.

Diff comments:

> diff --git a/debian/95-hwe-eol b/debian/95-hwe-eol
> index 3b4bd13..3c7fd03 100755
> --- a/debian/95-hwe-eol
> +++ b/debian/95-hwe-eol
> @@ -1,5 +1,11 @@
>  #!/bin/sh
>  
> +# this stamp is created and updated by /usr/lib/update-notifier/update-motd-hwe-eol
> +stamp="/var/lib/update-notifier/hwe-eol"
> +
> +# do not try to refresh this more than once per hour
> +[ -z "$(find "$stamp" -newermt 'now-1 hours' 2> /dev/null)" ] && exit 0

I don't recall what information the hwe-eol script provides but I'd be surprised if it needed updating every hour. Could we extend the check out even further? Perhaps daily?

> +
>  if [ -x /usr/lib/update-notifier/update-motd-hwe-eol ]; then
>      exec /usr/lib/update-notifier/update-motd-hwe-eol
>  fi


-- 
https://code.launchpad.net/~paelzer/update-notifier/+git/update-notifier/+merge/418122
Your team Ubuntu Core Development Team is subscribed to branch update-notifier:master.




More information about the Ubuntu-reviews mailing list