[Merge] ubuntu-release-upgrader:server-mode-check into ubuntu-release-upgrader:ubuntu/main

[Brian Murray]

Brian Murray has proposed merging ubuntu-release-upgrader:server-mode-check into ubuntu-release-upgrader:ubuntu/main.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1955047 in ubiquity (Ubuntu): "Nvidia drivers are marked as "auto" at installation and thus removed by `apt autoremove`"
  https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1955047

For more details, see:
https://code.launchpad.net/~ubuntu-core-dev/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/428277

Looking at the calls to self.cache.need_server_mode() in DistUpgradeController.py one of them can do more harm than good by switching from a "desktop" mode upgrade to a "server" mode upgrade. This changes that by only calling the function again if "server" mode is already set.

I tested an upgrade of an Ubuntu 20.04 server install with this change and it worked without issue. Additionally, I tested a desktop upgrade of Ubuntu 22.04 (only the calculation of the DistUpgrade) and it also worked without an issue.

It might also be necessary to reset `os.environ["RELEASE_UPGRADE_MODE"]`, however it looks like there is an existing bug with it not being set after changing mode.
-- 
The attached diff has been truncated due to its size.
Your team Ubuntu Core Development Team is requested to review the proposed merge of ubuntu-release-upgrader:server-mode-check into ubuntu-release-upgrader:ubuntu/main.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 524288 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20220812/be95390d/attachment-0001.diff>