[Merge] ~nteodosio/software-properties:ubuntu/master into software-properties:ubuntu/master
Nathan Teodosio
mp+434360 at code.launchpad.net
Fri Dec 9 14:57:07 UTC 2022
Thank you for the review, Robert!
I addressed your comments, except for moving the non-GUI logic to a separate file. This is because I just learned that the magic enablement also needs attachment, which I already fixed here, but, you will note, with some redundancy.
Once I get that into GIS too, I can come back here to make that part cleaner.
--
https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/434360
Your team Ubuntu Core Development Team is subscribed to branch software-properties:ubuntu/master.
More information about the Ubuntu-reviews
mailing list