[Merge] ~nteodosio/software-properties:threading into software-properties:ubuntu/master

Nathan Teodosio mp+434815 at code.launchpad.net
Fri Dec 16 18:55:16 UTC 2022


Nathan Teodosio has proposed merging ~nteodosio/software-properties:threading into software-properties:ubuntu/master.

Requested reviews:
  Sebastien Bacher (seb128)

For more details, see:
https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/434815

GLib.Thread is not available in Bionic and Focal: https://gitlab.gnome.org/GNOME/glib/-/issues/602.

Use Python threading module.

Also need to let daemonic threads go lest software-properties becomes uncloseable after invoking the UA attach dialog without subsequent verification of the PIN in the magic attach flow.

That, in my reading, is backed up by the definition of daemonic thread[1]:

> A thread can be flagged as a “daemon thread”. The significance of this flag is that the entire Python program exits when only daemon threads are left.

[1]: https://docs.python.org/3/library/threading.html
-- 
Your team Ubuntu Core Development Team is subscribed to branch software-properties:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1772 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20221216/ee9abdb8/attachment.diff>


More information about the Ubuntu-reviews mailing list