[Merge] ~ikapelyukhin/livecd-rootfs/+git/livecd-rootfs:master-unset-initrdless-boot-fallback into livecd-rootfs:ubuntu/master

Ivan Kapelyukhin mp+415413 at code.launchpad.net
Thu Feb 10 22:40:49 UTC 2022


Ivan Kapelyukhin has proposed merging ~ikapelyukhin/livecd-rootfs/+git/livecd-rootfs:master-unset-initrdless-boot-fallback into livecd-rootfs:ubuntu/master.

Commit message:
fix: unset initrdless_boot_fallback_triggered instead of setting it to 0

This fixes GCE shielded VM instances integrity monitoring failures on
focal and later. Our images are built with an empty /boot/grub/grubenv
file, however after the first boot `initrdless_boot_fallback_triggered`
is set to 0. This change in `grubenv` results in integrity monitoring
`lateBootReportEvent` error.

It seems that the only thing that's checking for this `grubenv` variable
is `grub-common.service`, and it is looking specifically for a `1`
value:

  if grub-editenv /boot/grub/grubenv list | grep -q
  initrdless_boot_fallback_triggered=1; then echo "grub:
  GRUB_FORCE_PARTUUID set, initrdless boot paniced, fallback triggered.";
  fi

Unsetting this variable instead of setting it to 0 would prevent issues
with integrity monitoring.


Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1960564 in livecd-rootfs (Ubuntu): "GCE shielded VM integrity monitoring reports errors"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1960564

For more details, see:
https://code.launchpad.net/~ikapelyukhin/livecd-rootfs/+git/livecd-rootfs/+merge/415413
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~ikapelyukhin/livecd-rootfs/+git/livecd-rootfs:master-unset-initrdless-boot-fallback into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 449 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20220210/1118956b/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list